Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart error -- no FisherS example #5

Closed
EricThomson opened this issue Mar 10, 2021 · 1 comment
Closed

Quickstart error -- no FisherS example #5

EricThomson opened this issue Mar 10, 2021 · 1 comment

Comments

@EricThomson
Copy link

Minor issue. The last line of the quickstart page throws an error:

print(danco.dimension_, fishers.dimension_, np.mean(lpca.dimension_pw_))

As the fisher instance was never implemented. Adding a line like the following fixes it:
fishers = skdim.id.FisherS().fit(data)
@j-bac
Copy link
Collaborator

j-bac commented Mar 10, 2021

Indeed, thanks for reporting !

@j-bac j-bac closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EricThomson @j-bac