Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py should contain numba in INSTALL_REQUIRES #9

Closed
bonheml opened this issue Oct 19, 2021 · 1 comment
Closed

setup.py should contain numba in INSTALL_REQUIRES #9

bonheml opened this issue Oct 19, 2021 · 1 comment

Comments

@bonheml
Copy link

bonheml commented Oct 19, 2021

Hi,
When numba is not installed, FisherS fails with the error

_FisherS.py, line 33, in <module>
    import numba as nb
ModuleNotFoundError: No module named 'numba'

Line 33, indeed imports numba which is missing in the INSTALL_REQUIRES.

I would suggest changing the INSTALL_REQUIRES to:

INSTALL_REQUIRES = ["numpy", "scipy", "scikit-learn", "numba"]

to prevent this.

Very good package!

@j-bac
Copy link
Collaborator

j-bac commented Oct 19, 2021

Thanks for reporting! Just fixed it. Cheers

@j-bac j-bac closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants