Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder and file naming convention #49

Closed
agoscinski opened this issue Jan 21, 2021 · 3 comments
Closed

Folder and file naming convention #49

agoscinski opened this issue Jan 21, 2021 · 3 comments
Milestone

Comments

@agoscinski
Copy link
Collaborator

To be closer to the naming convention of sklearn some propositions how to change the naming:

subpackage naming

  • pcovr -> decomposition
  • selection -> feature_selection

filename convention in subpackages:

  • filename.py -> _filename.py (this is not that important I guess)
  • base classes of a subpackage to a _base.py

test naming convention:

  • subpackage/test_filename.py (I wouldn't be strict about the class structure, one test class might cover multiple classes)
@rosecers
Copy link
Collaborator

rosecers commented Feb 2, 2021

In general in favor, although issues arise with sample selection.

@agoscinski
Copy link
Collaborator Author

agoscinski commented Feb 2, 2021

decided to move selector to feature_selection and have a wrapper code in selection (EDIT or other way around)

@agoscinski agoscinski added this to the 0.0.1 milestone Mar 3, 2021
@rosecers
Copy link
Collaborator

Addressed in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants