Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Ill-conditioned residual matrix in AA can lead to wasted computations #37

Open
PABannier opened this issue Jun 27, 2022 · 1 comment

Comments

@PABannier
Copy link
Collaborator

PABannier commented Jun 27, 2022

As AA has been refactored in a class, we should make sure to catch a sneaky bug that can make AA fail silently.
I've already stumbled upon cases where the residual matrix is ill-conditioned, which makes the solution of the quadratic problem associated to AA take very large positive and very small negative values which cancel out.
This bug is not caught by the try - except block paying attention to LinAlgError, and computational time is wasted.

We should make sure to catch this bug in the AA class.

See https://github.com/scikit-learn-contrib/skglm/blob/main/skglm/solvers/cd_solver.py#L295 for more detailed explanation.

@PABannier PABannier changed the title BUG - Anderson acceleration for very large values BUG - Ill-conditioned residual matrix in AA can lead to wasted computations Jun 27, 2022
@Badr-MOUFAD
Copy link
Collaborator

Can you provide a case that reproduces this behavior?
After fixing the bug, we shall use it to make a unitest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants