Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use nextafter to get eps #11608

Closed
amueller opened this issue Jul 17, 2018 · 4 comments
Closed

don't use nextafter to get eps #11608

amueller opened this issue Jul 17, 2018 · 4 comments
Labels
Easy Well-defined and straightforward way to resolve help wanted

Comments

@amueller
Copy link
Member

We're using np.nextafter(0, 1) to get an epsilon in a couple of places (git grep nextafter). We should be using dtype.eps, I think.
@amueller amueller added Easy Well-defined and straightforward way to resolve help wanted labels Jul 17, 2018
This was referenced Jul 17, 2018
Open
Merged
@timfong1015
Copy link

I am a new contributor (just been a scikit-learn user so far) and would be happy to help with this problem.

@amueller
Copy link
Member Author

@timfong1015 I already posted an issue in #11611.

@timfong1015
Copy link

Sorry for the bother. I didn't understand what was happening with #11611.

@qinhanmin2014
Copy link
Member

@timfong1015 We replaced np.nextafter(0, 1) with dtype.eps and solved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amueller @qinhanmin2014 @timfong1015