Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of setting weight coefficients in OPTICS algorithm. #12394

Closed
sergeirubinsky opened this issue Oct 16, 2018 · 16 comments
Closed

Possibility of setting weight coefficients in OPTICS algorithm. #12394

sergeirubinsky opened this issue Oct 16, 2018 · 16 comments
Labels
Enhancement Moderate Anything that requires some knowledge of conventions and best practices module:cluster wontfix We won't be fixing this issue

Comments

@sergeirubinsky
Copy link

We are very interested in your efforts on development and enhancement of OPTICS program sklearn implementation. It would be very important in our job (github.com/alashkov83/hydrocluster) to have possibility of setting weights, as it has been made in DBSCAN. Please inform us about your further plans.
A.Laskov, S.Rubinsky

@jnothman jnothman added New Feature Enhancement Moderate Anything that requires some knowledge of conventions and best practices help wanted labels Oct 16, 2018
@jnothman
Copy link
Member

This sounds useful. I wonder if, like in DBSCAN, the only thing that really needs to change is the determination of core points (or perhaps core distances too).

(I'm also chuffed that something I wanted for my own work at the time I proposed and implemented - sample_weight in DBSCAN - is being so appreciated!)

@thoo
Copy link

thoo commented Oct 16, 2018

@sergeirubinsky If you are not working on it, I would like to give a try. Thanks!!!

@adrinjalali
Copy link
Member

@thoo there are some major changes in the pipeline to OPTICS in progress. You probably should wait for those to get in first.

@thoo
Copy link

thoo commented Oct 16, 2018

@adrinjalali Thanks. I wiil.

@jnothman
Copy link
Member

jnothman commented Oct 16, 2018 via email

@sergeirubinsky
Copy link
Author

@sergeirubinsky If you are not working on it, I would like to give a try. Thanks!!!

We ourselves work on bioinformatics and would be glad you to try the problem.

@qinhanmin2014
Copy link
Member

A note to everyone here: Our OPTICS is experimental now. There're some known bugs and we're likely to change the API in the future.
But yes, this seems to be an useful feature.

@adrinjalali
Copy link
Member

@thoo you can work on this one if you want now.

@trabbart
Copy link

There was no comments or PR's for few months so I have started working on this.

@MitalPattani
Copy link

@trabbart Are you still on this, I would like to start on this otherwise.

@trabbart
Copy link

trabbart commented Feb 24, 2021

@MitalPattani I have stoped working on this and I do not have enough time to finish it in the future.

@MitalPattani
Copy link

Okay, I am working on this.

@OmarManzoor
Copy link
Contributor

@adrinjalali Can I try working on this?

@adrinjalali
Copy link
Member

I remember some major challenges here, but it'd be nice to try and see what comes out @OmarManzoor

@OmarManzoor
Copy link
Contributor

I remember some major challenges here, but it'd be nice to try and see what comes out @OmarManzoor

After looking at this as well as at the closed PR linked with this issue, I think one of the challenges might be to come up with an efficient implementation of the code.

@adrinjalali
Copy link
Member

So in #25855 we decided it's a wontfix issue. I think it applies here as well. Closing as won't fix, happy to re-open if others think otherwise.

@adrinjalali adrinjalali closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
@adrinjalali adrinjalali added wontfix We won't be fixing this issue and removed help wanted labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Moderate Anything that requires some knowledge of conventions and best practices module:cluster wontfix We won't be fixing this issue
Projects
None yet
Development

No branches or pull requests

9 participants