Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] --record {plist} records a directory #12681

Closed
yurivict opened this issue Nov 27, 2018 · 7 comments
Closed

[regression] --record {plist} records a directory #12681

yurivict opened this issue Nov 27, 2018 · 7 comments
Labels
Needs Decision - Close Requires decision for closing

Comments

@yurivict
Copy link

The --record {plist} command shouldn't record directories, but it did:

/usr/local/lib/python2.7/site-packages/sklearn/datasets/tests/data/openml

As a result, the FreeBSD port fails now:

===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PYTHON_SITELIBDIR%%/sklearn/datasets/tests/data/openml
@amueller
Copy link
Member

Can you please give some more context? what's the command?

@amueller
Copy link
Member

I guess the context is here:
sfepy/sfepy#455 (comment)

Given that the only google hit is you asking a simliar question on a different package and the people there not knowing the context means that maybe you could report with a bit more context ;)

@amueller
Copy link
Member

Can't reproduce on ubuntu.

@yurivict
Copy link
Author

The element ending with sklearn/datasets/tests/data/openml appears in the plist, but isn't supposed to.

@yurivict
Copy link
Author

FreeBSD seems to be the only system using this standard python feature, so many people don't know about it.

@amueller
Copy link
Member

yeah, looks like it. But the record generated on linux also doesn't contain that file.

@thomasjpfan thomasjpfan added the Needs Decision - Close Requires decision for closing label Feb 27, 2022
@thomasjpfan
Copy link
Member

I am closing this issue since is ~ 3 years old and there is no resolution. Also distuils is deprecated in Python, and scikit-learn going to move to a new build system: #21499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision - Close Requires decision for closing
Projects
None yet
Development

No branches or pull requests

3 participants