You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #13046, we have redundant code in estimator which should support string dtype (object dtype). Those estimators should make similar validation and raise consistent errors and have (a) common test(s).
The estimators which are involved will be:
SimpleImputer
MissingIndicator
OneHotEncoder
OrdinalEncoder
I open this issue such that we can agree on the way to refactor this part.
The text was updated successfully, but these errors were encountered:
No, I propose to make all common tests use the X_types to figure out what training data to use. Right now most checks can't be performed for, say, CountVectorizer (or OneHotEncoder) because we can't train it because all the tests use float data for fitting.
Following #13046, we have redundant code in estimator which should support string dtype (object dtype). Those estimators should make similar validation and raise consistent errors and have (a) common test(s).
The estimators which are involved will be:
I open this issue such that we can agree on the way to refactor this part.
The text was updated successfully, but these errors were encountered: