Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamma hyperparameter misspecified on KernelPCA #13099

Open
Guillermogsjc opened this issue Feb 6, 2019 · 3 comments
Open

gamma hyperparameter misspecified on KernelPCA #13099

Guillermogsjc opened this issue Feb 6, 2019 · 3 comments

Comments

@Guillermogsjc
Copy link

There is a missespecification on _get_kernel method at KernelPCA class.

If you perform the inverse_transform method specifiying gamma as None or directly imputing the value 1 / X.shape[1], it will differ, as the _get_kernel function with gamma as None adjusts to the X data both in transform and at inverse_transform methods.

The consequence is that specifying the supposed default hyperparameter leads to different results than leaving it as None.

The proposal is to add a hyperparameter called inverse_gamma or something like that for disambiguation.

@Guillermogsjc Guillermogsjc changed the title _get_kernel missespecified on KernelPCA gamma hypeparameter missespecified on KernelPCA Feb 6, 2019
@Guillermogsjc Guillermogsjc changed the title gamma hypeparameter missespecified on KernelPCA gamma hyperparameter misspecified on KernelPCA Feb 6, 2019
@Guillermogsjc
Copy link
Author

The override on the link works fine.

@jnothman
Copy link
Member

jnothman commented Feb 6, 2019 via email

@Guillermogsjc
Copy link
Author

mmm, have to check the other kernel hyperparams that should have an "inverse" option I guess... coef0 and degree. As soon as I have time I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants