Fix for AttributeError thrown when calling metrics.pairwise_distances with binary metrics and Y is None #13864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
May 12, 2019
Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>
jnothman
reviewed
May 12, 2019
ogrisel
approved these changes
May 13, 2019
|
@rick2047 thanks for your contrib. I pushed a non-regression test for you because we want to get 0.21.1 out soon. |
|
@jnothman merge? |
jnothman
approved these changes
May 13, 2019
|
Thanks @rick2047! |
|
@jnothman oh I'm so excited right now. You have no idea. I've tried for years to actually get some code committed an open source project. This is brilliant. |
|
Congrats @rick2047! |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 14, 2019
… with binary metrics and Y is None (scikit-learn#13864)
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 14, 2019
… with binary metrics and Y is None (scikit-learn#13864)
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
… with binary metrics and Y is None (scikit-learn#13864)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13853.
Fixed by using lazy or evaluation. Check if Y is none, if not none then check if its bool.