Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return_all_estimators option in GridSearch and RandomizedSearch #16765

Open
Thomasillo opened this issue Mar 25, 2020 · 3 comments
Open

return_all_estimators option in GridSearch and RandomizedSearch #16765

Thomasillo opened this issue Mar 25, 2020 · 3 comments

Comments

@Thomasillo
Copy link

Describe the workflow you want to enable

I would like to have an option in the GridSearchCV and RandomizedSearchCV
that enables storing of the (re)fitted estimator for all parameter combinations.

The background is that I'm working with highly correlated timeseries data and try to find the best
way to set up cross validation.

I have a test set set aside and want to examine for which cross validation strategy, the CV score correlates best with the score on the test set.

Currently, only the "best" estimator is stored thus not allowing to evaluate the others on the test set.

Describe your proposed solution

A slight modification of BaseSearchCV should do the trick. I would give it a shot if appreciated and the above makes sense.

@raduspaimoc
Copy link
Contributor

@Thomasillo Hey, Is there any way in which I could contribute to this new feature?

@chrispe
Copy link

chrispe commented Apr 14, 2020

I would also be interested to work on this. Has it been picked up by somebody else already? Thanks.

@chrispe
Copy link

chrispe commented Apr 27, 2020

Since nobody responded, I took it on and submitted a pull request as you see above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants