Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fix parametrize_with_checks link #17263

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

rth
Copy link
Member

@rth rth commented May 18, 2020

The link to parametrize_with_checks under "Rolling your own estimator" is currently not working
https://scikit-learn.org/dev/developers/develop.html#rolling-your-own-estimator

@thomasjpfan thomasjpfan modified the milestone: 0.23.1 May 18, 2020
@thomasjpfan
Copy link
Member

I have always been unsure if we should include these types of fixes into the bugfix release, so the website gets updated.

What do you think?

@NicolasHug NicolasHug added this to the 0.23.1 milestone May 18, 2020
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rth

I have always been unsure if we should include these types of fixes into the bugfix release, so the website gets updated.

yeah I think we should

@rth
Copy link
Member Author

rth commented May 18, 2020

I also think that we should, even independently of minor bugfix releases for the documentation.

@rth rth merged commit 29f83f8 into master May 18, 2020
@rth rth deleted the fix-parametrize-with-checks-link branch May 18, 2020 15:39
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request May 18, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants