[MRG] Add threadpoolctl requirement to documentation #17273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that it is also missed from Runtime dependencies in the documentation. |
|
Thanks @alfaro96
Right. Do you mind adding it too in this PR ? |
alfaro96
changed the title
|
@jeremiedbb Here it is! |
alfaro96
changed the title
jeremiedbb
approved these changes
May 18, 2020
Merged
rth
approved these changes
May 18, 2020
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 18, 2020
* MNT Add threadpoolctl dependency to README.rst * MNT Add threadpoolctl dependency to advanced installation instructions
adrinjalali
pushed a commit
that referenced
this pull request
May 19, 2020
* MNT Add threadpoolctl dependency to README.rst * MNT Add threadpoolctl dependency to advanced installation instructions
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
* MNT Add threadpoolctl dependency to README.rst * MNT Add threadpoolctl dependency to advanced installation instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR documents that threadpoolctl is a dependency (requirement) to install scikit-learn.