Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 support for 1.0 #20084

Closed
rth opened this issue May 12, 2021 · 5 comments · Fixed by #20069
Closed

Drop Python 3.6 support for 1.0 #20084

rth opened this issue May 12, 2021 · 5 comments · Fixed by #20069

Comments

@rth
Copy link
Member

rth commented May 12, 2021 •
edited

Not sure when we were planning to drop Python 3.6 support? NEP 29 suggested to do that last year, and there are no bug fix releases for 3.6 since 2018. Ubuntu 2020 LTS has Python 3.8.

numpy, scipy and pandas have already made a Python 3.7+ release, so it's probably time for us as well, and 1.0 could be a good occasion to do so.

This would simplify CI/ maintenance work a bit.
@rth rth changed the title Drop Python 3.6 for 1.0 Drop Python 3.6 support for 1.0 May 12, 2021
@rth rth mentioned this issue May 12, 2021
Closed
@cmarmo
Copy link
Member

cmarmo commented May 12, 2021 •
edited

Happy to drop it in #20069 ... :)

@ogrisel
Copy link
Member

ogrisel commented May 12, 2021

Ok for dropping 3.6 as well.

Another point: google colab is now running 3.7.10 since a few months.

@cmarmo cmarmo mentioned this issue May 12, 2021
Merged
@NicolasHug
Copy link
Member

sounds good

@rth
Copy link
Member Author

rth commented May 13, 2021

As mentioned by @cmarmo in #20069 (comment) this would also imply that we would need to update minimal numpy, and scipy to versions that support Python 3.7 wheels (1.14.5 and 1.1.0 respectively).

@glemaitre
Copy link
Member

glemaitre commented May 17, 2021 •
edited

+1

@PGijsbers PGijsbers mentioned this issue May 18, 2021
Open
This was referenced May 20, 2021
Closed
Merged
@ulupo ulupo mentioned this issue Jun 11, 2021
Closed
@akihironitta akihironitta mentioned this issue Oct 18, 2021
Closed
1 task
@NicolasGensollen NicolasGensollen mentioned this issue Oct 20, 2021
Merged
@LysandreJik LysandreJik mentioned this issue Aug 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] CI Push Scipy minimum version to 1.1.0. Remove Python 3.6 from builds. cmarmo/scikit-learn
5 participants
@ogrisel @rth @NicolasHug @cmarmo @glemaitre