Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous tests for ensemble max_samples & bootstrap #21299

Closed
PSSF23 opened this issue Oct 10, 2021 · 3 comments · Fixed by #21295
Closed

Fix ambiguous tests for ensemble max_samples & bootstrap #21299

PSSF23 opened this issue Oct 10, 2021 · 3 comments · Fixed by #21295

Comments

@PSSF23
Copy link
Contributor

PSSF23 commented Oct 10, 2021

Describe the bug

In some tests for ensembles, such as test_max_samples_boundary_regressors and test_max_samples_boundary_classifiers, the bootstrap parameter is not specified. Yet for some of the estimators tested, they have bootstrap=False by default, including ExtraTreesClassifier, ExtraTreesRegressor and more.

Related to #21294

Steps/Code to Reproduce

Simplified e.g.

test_max_samples_boundary_regressors(ExtraTreesRegressor)

Expected Results

Some error is thrown due to bootstrap=False.

Actual Results

The test pass without errors.

Versions

System:
    python: 3.8.5 (default, Sep  4 2020, 02:22:02)  [Clang 10.0.0 ]
executable: /Users/pssf23/miniconda3/envs/ndd/bin/python
   machine: macOS-10.16-x86_64-i386-64bit

Python dependencies:
          pip: 20.3.3
   setuptools: 58.2.0
      sklearn: 1.0
        numpy: 1.19.5
        scipy: 1.7.1
       Cython: 0.29.21
       pandas: 1.2.0
   matplotlib: 3.3.3
       joblib: 1.0.0
threadpoolctl: 2.1.0

Built with OpenMP: True
@PSSF23
Copy link
Contributor Author

PSSF23 commented Oct 10, 2021

Take

@glemaitre
Copy link
Member

I remove the bug tag because this is just that the parameter is ignored. It is stated in the documentation but could be improved of course.

@PSSF23
Copy link
Contributor Author

PSSF23 commented Nov 23, 2021

@glemaitre Sure! I updated my comment to include more reasons on the improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants