Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behavior of GaussianProcessRegressor.sample_y's random_state variable. #25767

Open
ominusliticus opened this issue Mar 6, 2023 · 2 comments · May be fixed by #25789
Open

Change default behavior of GaussianProcessRegressor.sample_y's random_state variable. #25767

ominusliticus opened this issue Mar 6, 2023 · 2 comments · May be fixed by #25789

Comments

@ominusliticus
Copy link

Describe the workflow you want to enable

I think it is misleading to have the sample_y method to default to reproduce the same sample every time it is called.
The default value for random_state should be None, and the documentation sample_y should state that None ensures random behavior.

Describe your proposed solution

Please see above box

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@ominusliticus ominusliticus added Needs Triage Issue requires triage New Feature labels Mar 6, 2023
@thomasjpfan
Copy link
Member

Thank you for opening this issue! I agree it is strange to fix the random state in sample_y. For us to change the default, we would need to go through a deprecation cycle. Are you interested in opening a PR with the change?

@thomasjpfan thomasjpfan added API module:gaussian_process and removed Needs Triage Issue requires triage labels Mar 8, 2023
@ominusliticus
Copy link
Author

Absolutely! I will get right on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants