New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Deprecate paired_distances
and paired_*_distances
#26982
Comments
paired_distances
and paired_-_distances
paired_distances
and paired_*_distances
I am +1 regarding deprecating and removing I think we need to know if |
I'm in favor of deprecating them all, if too many users complain, we can reverse action, but the implementation is trivial, so we shouldn't have any issues removing them. |
@StefanieSenger this is a medium-scope task, in case you would be interested in taking it on. If not I can mark it as |
Would like to open PR |
Seen the ping only now. If there is something I can support you with, @Shreesha3112, please let me know. :) |
Background
We have several public functions
paired_*_distances
which exist primarily as specialized implementations for the publicpaired_distances
function. This function is thus either a wrapper around the specializedpaired_*_distances
or a simple iteration over the input data. During the drafting meeting, we discussed the deprecation of these functions. This discussion continued on a recent PR (start here). I wanted to open this to see if we could come to a quick consensus on our intent for thepaired_*
functions.Personally, I definitely want to see
paired_*_distances
deprecated. I have no idea how widely usedpaired_distances
is in practice. I believe @thomasjpfan has a better sense of this after some github searches. If it is not too widely used, I am also in favor of deprecating it as a whole.As @adrinjalali mentioned (cf. comment) the
paired_distances
function is a really light function that most users ought to be able to write themselves. It doesn't really make sense for us to provide it for them...cc: @scikit-learn/core-devs
Edit: Consensus is to deprecate both
paired_*_distances
andpaired_distances
The text was updated successfully, but these errors were encountered: