Logistic Regression CV #2856
Closed
Logistic Regression CV #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using simple finite differences is not robust enough to noise. We have to use a linear regression
|
can you list the TODOs? thx |
|
@GaelVaroquaux It would be good if you could list the TODO's. I just pulled up your branch and I'm about to look through it. |
|
@GaelVaroquaux I'm going through the code, but it would be really nice of you could tell what work is remaining in this PR. Its a huge diff and would save me a lot of time. Thanks. |
|
Does it work? |
|
Ok. closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying on @GaelVaroquaux ' s work.