⚠️ CI failed on Check Manifest ⚠️

[scikit-learn-bot]

CI is still failing on Check Manifest (Apr 09, 2024)

[lesteve]

Very likely related to switching to meson as the main build backend #28506.

[jeremiedbb]

Looks like check-manifest doesn't support alternative build backends (mgedmin/check-manifest#163)

[betatim]

It looks like meson dist doesn't support being run on something that isn't a git repository. Is that also how you read the error message? If yes, it makes me wonder if we can contribute something to meson to make this work (no need to change check manifest)?

[lesteve]

Another option would be to switch to check-sdist as mentioned in mgedmin/check-manifest#163 (comment).

I quickly checked and it seems like pipx run check-sdist is happy and says:

Successfully built scikit_learn-1.5.dev0.tar.gz
SDist matches git

Full disclosure, I don't have a good grasp of what either check-manifest nor check-sdist is doing.

Probably a good thing to do would be something like numpy/numpy#23981 (comment) to make sure there are no major differences in the produced sdist between before and after switching to Meson as our main build backend.

Side-comment: to build a sdist it seems like people do:

python -m build --sdist

for example numpy:
https://github.com/numpy/numpy/blob/c3694335faffe35e3d961feffefdc0a4b9a665da/.github/workflows/wheels.yml#L220-L223

[ogrisel]

Looking at the check-sdist source code I think it should be quite helpful. +1 for replacing check-manifest by check-sdist on my side.

[lesteve]

I opened #28757 to tackle this.