Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT define a single time _estimator_has and refactor code #29046

Open
glemaitre opened this issue May 18, 2024 · 1 comment
Open

MAINT define a single time _estimator_has and refactor code #29046

glemaitre opened this issue May 18, 2024 · 1 comment

Comments

@glemaitre
Copy link
Member

From past discussion, I realized that we are defining the same _estimator_has in several places while it does exactly the same job and has the same semantic.

I think we should do a bit of cleaning by moving this function into a submodule in sklearn.utils. I would probably keep this function private for the moment even thought it could be useful for developers of third-party libraries.

Maybe @StefanieSenger would be interested in leading the effort since you should be familiar with this function after working on #28167?

@github-actions github-actions bot added the Needs Triage Issue requires triage label May 18, 2024
@glemaitre glemaitre added Enhancement and removed Needs Triage Issue requires triage labels May 18, 2024
@StefanieSenger
Copy link
Contributor

Oh yes, that's a good effort and a nice project to work on. Thank you, @glemaitre, I will open a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Easy
Development

No branches or pull requests

2 participants