-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version warning banner on the stable documentation page #29075
Comments
Let's see if merging #29071 fixed this |
Looks like this is now fixed 🎉 |
For the next release we need to figure out how we perform the update of |
This seems fixed indeed, thanks for noticing and opening an issue! |
What about #29077 instead of a "random" PR? If I'm not mistaken updating |
Describe the issue linked to the documentation
Currently https://scikit-learn.org/stable/index.html shows the version warning banner ("This are the docs for an unstable version").
![Screenshot 2024-05-22 at 09 08 02](https://private-user-images.githubusercontent.com/1448859/332694829-2b1e7309-b11f-4e92-8b80-1a6b96743d9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5NTk1OTUsIm5iZiI6MTcyMTk1OTI5NSwicGF0aCI6Ii8xNDQ4ODU5LzMzMjY5NDgyOS0yYjFlNzMwOS1iMTFmLTRlOTItOGI4MC0xYTZiOTY3NDNkOWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjZUMDIwMTM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDY4YzlkZTY3NGQ5YmJkNjA4MTAxNjZjMjU2MDMxNzI4N2FjYzE5OTNjOWY1MGJlNTdlNjFhOWQzZGZkZDc4NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ClvM-vv2eMIN9f0nZl8UMUGol667TDnI57_L3Jb1Zho)
I think this is happening because we haven't updated https://scikit-learn.org/dev/_static/versions.json which lists all the available versions and declares which is the stable version.
This file is generated by
build_tools/circle/list_versions.py
which should run as part of the CI onmain
. My guess as to why the file hasn't been updated is that we have not merged a PR since releasing v1.5.0. If I run the script locally it generates the correct content for the.json
file.Suggest a potential alternative/fix
I think the fix is to merge any PR into
main
as this will regenerate theversions.json
file.This is because all versions of the documentation read the versions from the same URL, which is based on
/dev/
.The text was updated successfully, but these errors were encountered: