Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogisticRegression.predict_proba is incorrect when multiclass='multinomial'. #5134

Closed
jagapiou opened this issue Aug 18, 2015 · 5 comments
Closed
Labels

Comments

@jagapiou
Copy link

Looking at the code for LogisticRegression.predict_proba it seems to assume that multiclass='ovr': it does sigmoid(wTx+b) and then normalizes over the classes. I think that when multiclass='multinomial' is used it should use softmax instead.

@agramfort
Copy link
Member

agramfort commented Aug 19, 2015 via email

@MechCoder
Copy link
Member

OK, I can fix this up tonight.

@jagapiou
Copy link
Author

I think this is an issue other places too: e.g. sklearn.lda.LDA.predict_proba

@amueller
Copy link
Member

Yes, looks to be the case.... argh :-/

@MechCoder
Copy link
Member

This was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants