New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website menu on mobile #7055
Comments
Digression: what's the point of the "need contributor" tag? Pretty much every issue needs a contributor ;) |
I suppose it's mainly for newcomers who want to contribute to the project. I noticed at the sprint that lots of people were struggling to find things to work on, which I feel could be mitigated if we were better about applying appropriate labels. |
Indeed but there is also the "easy" label for that. |
Re: the digression, if an Open issue has a PR contributed by someone, but the PR isn't yet merged, does one not work on the issue? How do I find an easy issue to work on that someone else hasnt already made a PR? |
@vharavu generally, you look at whether the reason the PR isn't merged is inactivity by the reviewers or inactivity by the submitter. If the submitter hasn't responded to the last round of reviews in awhile, it's reasonable to comment on the PR asking the submitter if they are still working on it / whether you can take over. If the reviewers haven't gotten back (likely case), it's generally best to not work on it. Ideally, to find an easy issue to work on that someone hasn't made a PR to, you'd just filter by "Need Contributor" and "Easy" ;). However, lots of issues that are easy and need a contributor are not tagged as such (hence my response to the digression). Untouched issues are generally on the first page of github; else you unfortunately have to look at every issue you're interested in and see if there's someone working on it (this is my experience at least, if someone has a better way please share! :) ) |
@amueller I'm interested in working on this. I am pretty crafty with front end web development and I'm new to machine learning. How would you like to coordinate the formatting of the website menu on mobile? |
@mblondel most issues don't actually need someone to jump in, they are already addressed by a PR, which needs either review or is waiting for the author to address the review. The idea is that once someone starts on an issue, the tag is removed. |
@Ajackster Great, pleas just go ahead with what you think is reasonable. We don't really look for an entire redesign. We are using bootstrap for the website, so in principle it shouldn't be that hard. |
@amueller Can we close this issue ? |
The website menu doesn't look great on mobile. We could probably improve.
This is a good issue for someone who wants to contribute but doesn't have a lot of machine learning experience.
The text was updated successfully, but these errors were encountered: