[MRG+2] Fixed memory leak in liblinear #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
|
thx what's our policy here. Try to push upstream or we gave up on this? |
|
From what I can tell, both affected functions are sklearn-specific changes. |
|
ok cool. Let's merge when CIs are happy then.
thx
|
|
LGTM +1 for merge when green. |
jnothman
changed the title
jnothman
changed the title
|
Thanks @superbobry |
|
triggered an circleci failure in building the docs: |
|
Oh :/ |
|
aaand now it passes without being touched. Could have been a random failure... |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
The leak resulted from two issues: - not freeing the problem struct - not freeing the number of iterations The former was present in the initial version of ``liblinear_helper.c`` while latter appeared after c8c72fd which introduced ``n_iter``. Closes scikit-learn#8499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8499
What does this implement/fix? Explain your changes.
scikit-learn version of liblinear had tow leaks:
The former was present in the initial version of
liblinear_helper.cwhile latter appeared after c8c72fd
which introduced
n_iter.Any other comments?
I'm surprised these leaks survived for so long :)