Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCM.fit_transform does not follow sklearn philosophy #17

Closed
remiadon opened this issue Apr 30, 2020 · 0 comments · Fixed by #29
Closed

LCM.fit_transform does not follow sklearn philosophy #17

remiadon opened this issue Apr 30, 2020 · 0 comments · Fixed by #29
Labels
enhancement New feature or request unplanned Unplanned Items
Projects

Comments

@remiadon
Copy link
Collaborator

Describe the workflow you want to enable

For now skmine.itemsets.LCM implements a fit_transform methods, returning a DataFrame
with two columns, namely itemsets and supports
To be fully compatible with sklearn this is not sufficient

Describe your proposed solution

move what the current fit_transform function is doing to a new function ("discover ?"), so we can still get a pretty dataframe with itemsets and supports,
and change the fit_transform method, so that:

  • it returns a binary pandas.DataFrame, with itemsets as column
  • the width of this DataFrame is constant and pre-defined (pass n_features as arg ?)

Additional context

Ideally we should be able to use our pattern mining algorithm to extract feature from transactional
datasets.
see this repo

@remiadon remiadon added the enhancement New feature or request label Apr 30, 2020
@remiadon remiadon added the unplanned Unplanned Items label May 11, 2020
@remiadon remiadon added this to To do in sprint 1 May 11, 2020
@remiadon remiadon linked a pull request May 11, 2020 that will close this issue
sprint 1 automation moved this from To do to Done May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unplanned Unplanned Items
Projects
No open projects
sprint 1
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant