Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first performance improvements for SLIM #32

Closed
remiadon opened this issue May 13, 2020 · 2 comments · Fixed by #46
Closed

first performance improvements for SLIM #32

remiadon opened this issue May 13, 2020 · 2 comments · Fixed by #46
Labels
enhancement New feature or request SLIM
Projects

Comments

@remiadon
Copy link
Collaborator

Describe your proposed solution

Two simple things to do:

  • right now SLIM make sure not to drop itemsets with zero usages when switching a codetable for a new, more concise one. This results in a final codetable with a lot of empty usage lists. Decide where to drop those zeros, and where to let them will lead to better run time and user experience
  • Like mentionned in the litterature, when considering a new candidate, reduce the database to itemsets containing all items in this itemset. This will make computation of covers faster
@remiadon remiadon added the enhancement New feature or request label May 13, 2020
@remiadon remiadon added this to To do in sprint 2 May 13, 2020
@remiadon
Copy link
Collaborator Author

mentioned in #8

Binary representation may help us:

  • computing covers faster than with a naive iterative algorithm
  • improving inference time, i.e runtimes for .predict_* methods, which is linked to computing covers faster

@remiadon
Copy link
Collaborator Author

Added to this : present a use case on 20news group

@remiadon remiadon added the SLIM label May 19, 2020
@remiadon remiadon moved this from To do to In progress in sprint 2 May 19, 2020
@remiadon remiadon linked a pull request Jun 2, 2020 that will close this issue
@remiadon remiadon closed this as completed Jun 2, 2020
sprint 2 automation moved this from In progress to Done Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SLIM
Projects
No open projects
sprint 2
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant