Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"interactions with sklearn" page in the doc #36

Closed
remiadon opened this issue May 19, 2020 · 8 comments
Closed

"interactions with sklearn" page in the doc #36

remiadon opened this issue May 19, 2020 · 8 comments
Labels
documentation Improvements or additions to documentation SKLEARN-COMPAT
Projects

Comments

@remiadon
Copy link
Collaborator

No description provided.

@remiadon remiadon added the documentation Improvements or additions to documentation label May 19, 2020
@remiadon remiadon added this to To do in sprint 2 May 19, 2020
@remiadon
Copy link
Collaborator Author

see 090f27f

sprint 2 automation moved this from To do to Done May 20, 2020
@alexandre-termier
Copy link
Collaborator

First version of this page is really nice, congrats!

For the Preprocessing section, we should have an example (through a link to a tutorial for example). Here, it says that sometimes we need to do things differently than sklearn, and that Preprocessing does the heavy lifting for the user, but this remains too abstract.
Ideally, the reader should get some basic idea on the cases where it will require to use the Preprocessing elements of sk-mine.

@remiadon remiadon reopened this May 20, 2020
sprint 2 automation moved this from Done to In progress May 20, 2020
@remiadon
Copy link
Collaborator Author

@alexandre-termier agreed
Should we include a link to an example and in-line a self-explanatory example ?

@alexandre-termier
Copy link
Collaborator

If this is possible, this would be perfect!

@remiadon
Copy link
Collaborator Author

@alexandre-termier sorry I'll rephrase
Should we include a link to an example OR in-line a self-explanatory example ?

@alexandre-termier
Copy link
Collaborator

My bad, I did not understood.
Link to example should have priority.

@remiadon
Copy link
Collaborator Author

@remiadon
Copy link
Collaborator Author

DONE, see 090f27f and 3111194

sprint 2 automation moved this from In progress to Done May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SKLEARN-COMPAT
Projects
No open projects
sprint 2
  
Done
Development

No branches or pull requests

2 participants