Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when running gravity.fit(fdf, relevance_column = 'population') #224

Closed
jonpappalord opened this issue Mar 1, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jonpappalord
Copy link
Member

When running gravity.fit(fdf, relevance_column = 'population') I get this error:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Input In [21], in <module>
     13 gravity = Gravity(gravity_type = 'singly constrained')
     14 print(gravity)
---> 16 gravity.fit(fdf, relevance_column = 'population')
     17 print(gravity)
     19 fdf_fitted = gravity.generate(tessellation, relevance_column = 'population',
     20                               out_format = 'probabilities', tile_id_column = 'tile_id')

File /opt/anaconda3/envs/skmob/lib/python3.9/site-packages/skmob/models/gravity.py:474, in Gravity.fit(self, flow_df, relevance_column)
    471 flow_df.apply(lambda flow_example: self._update_training_set(flow_example), axis=1)
    473 # Perform GLM fit
--> 474 poisson_model = GLM(self.y, self.X, family=sm.genmod.families.family.Poisson(link=sm.genmod.families.links.log))
    475 poisson_results = poisson_model.fit()
    477 # Set best fit parameters

File /opt/anaconda3/envs/skmob/lib/python3.9/site-packages/statsmodels/genmod/families/family.py:401, in Poisson.__init__(self, link)
    399 if link is None:
    400     link = L.Log()
--> 401 super(Poisson, self).__init__(link=link, variance=Poisson.variance)

File /opt/anaconda3/envs/skmob/lib/python3.9/site-packages/statsmodels/genmod/families/family.py:83, in Family.__init__(self, link, variance)
     78 if inspect.isclass(link):
     79     warnmssg = (
     80         "Calling Family(..) with a link class is not allowed. Use an "
     81         "instance of a link class instead."
     82     )
---> 83     raise TypeError(warnmssg)
     84 else:
     85     self.link = link

TypeError: Calling Family(..) with a link class is not allowed. Use an instance of a link class instead.
@jonpappalord jonpappalord added the bug Something isn't working label Mar 1, 2022
@jonpappalord jonpappalord added this to the v1.2.4 milestone Mar 1, 2022
@FilippoSimini
Copy link
Member

fixed by PR #225

@ajahanba
Copy link

This issue is not fixed yet. I still experience the same error.

@miccferr miccferr mentioned this issue May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants