Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renumbering network should update port names #1074

Closed
ASLOBEAR opened this issue May 21, 2024 · 2 comments
Closed

Renumbering network should update port names #1074

ASLOBEAR opened this issue May 21, 2024 · 2 comments
Labels
Feature Request Wished Feature

Comments

@ASLOBEAR
Copy link

As a sanity check for port renumbering, it would be helpful if the port names Network.port_names (if populated) are updated with the new port order when Network.renumber or Network.renumbered is called
@ASLOBEAR ASLOBEAR added the Feature Request Wished Feature label May 21, 2024
@jhillairet
Copy link
Member

You mean, after creating a Network using Circuit ?

@ericwrice ericwrice mentioned this issue Jun 7, 2024
Merged
@mhuser
Copy link
Collaborator

mhuser commented Jul 14, 2024

Done in #1089

@mhuser mhuser closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Wished Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhillairet @mhuser @ASLOBEAR