Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonlinearLeastSquaresProblem dispatch for modelingtoolkitize #2669

Closed
pao opened this issue Apr 24, 2024 · 0 comments · Fixed by #2847
Closed

Add NonlinearLeastSquaresProblem dispatch for modelingtoolkitize #2669

pao opened this issue Apr 24, 2024 · 0 comments · Fixed by #2847

Comments

@pao
Copy link

pao commented Apr 24, 2024

Is your feature request related to a problem? Please describe.

There is not currently a dispatch for NonlinearLeastSquaresProblem in the modelingtoolkitize function, so those kinds of problems cannot be...toolkitized?

julia> @mtkbuild sys = modelingtoolkitize(safehouse.prob)
ERROR: MethodError: no method matching modelingtoolkitize(::NonlinearLeastSquaresProblem{…}; name::Symbol)

Closest candidates are:
modelingtoolkitize(::OptimizationProblem; kwargs...)
@ ModelingToolkit C:\julia\packages\ModelingToolkit\kByuD\src\systems\optimization\modelingtoolkitize.jl:6
modelingtoolkitize(::SDEProblem; kwargs...)
@ ModelingToolkit C:\julia\packages\ModelingToolkit\kByuD\src\systems\diffeqs\modelingtoolkitize.jl:173
modelingtoolkitize(::ODEProblem; kwargs...)
@ ModelingToolkit C:\julia\packages\ModelingToolkit\kByuD\src\systems\diffeqs\modelingtoolkitize.jl:6
...

Describe the solution you’d like

Please add the missing dispatch (it sounds like we already know what needs doing here per a Slack discussion.)

cc @ChrisRackauckas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant