Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient broadcast overloads for AbstractVectorOfArray #5

Closed
ChrisRackauckas opened this issue May 3, 2017 · 3 comments
Closed

Efficient broadcast overloads for AbstractVectorOfArray #5

ChrisRackauckas opened this issue May 3, 2017 · 3 comments

Comments

@ChrisRackauckas
Copy link
Member

It can broadcast along the linear index. This will make its broadcast performant for most analyses, and so the only indexing performance issue could be from directly using the matrix indexing.

@ChrisRackauckas
Copy link
Member Author

the fallbacks using Cartesians actually do super well. I don't think overloads are needed for speed. It is annoying that it returns a standard Vector{Array} though.

@ChrisRackauckas
Copy link
Member Author

@ScottPJones I know you've been looking at this stuff: do you know how you can add something to say "make it return a VectorOfArray"?

@ScottPJones
Copy link
Contributor

I wish I did, that's the same problem that I've been running into with trying to get the broadcasting of MultiScaleArrays to work, if you don't add specializations for broadcast!, broadcast, it just returns Vector{T}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants