New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save #define flags into libsnark-config.h #21

Open
tromer opened this Issue Oct 23, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@tromer
Member

tromer commented Oct 23, 2015

Currently we have a bunch of #define flags fed by the makefile as g++ -D... arguments during the build. But after we build a library file (libsnark.a or libsnark.so), the information on choice of flags is lost. Later, if a user compiling against the libsnark library happens to use different flags, all bets are off. This is especially bad because some of our code is in .c files (so affeceted by the flags when compiling libsnark), and other is in .tcc files (so affected by the flags when compiling the user's app).

Let's save the flags into a libsnark_config.h file and #include it from all pertinent places in libsnark, instead of passing g++ -D arguments. Then, make install can then install it with the rest of the headers.

@tromer tromer changed the title from Save #define flags into an .h file to Save #define flags into libsnark-config.h Oct 23, 2015

@tromer tromer added the buildsystem label Jan 25, 2017

@tromer tromer referenced this issue Jan 26, 2017

Open

Link example #47

@tromer

This comment has been minimized.

Show comment
Hide comment
@tromer

tromer Jan 26, 2017

Member

Related to #65.

Member

tromer commented Jan 26, 2017

Related to #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment