Skip to content

Commit

Permalink
MAINT: setup.py: enable Cython generation for sdist in released versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@pv
pv committed Mar 24, 2013
1 parent 275e105 commit c012492
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
View file
Expand Up @@ -220,7 +220,7 @@ def setup_package():
else: else:
from numpy.distutils.core import setup from numpy.distutils.core import setup


if not ISRELEASED: if not ISRELEASED or 'sdist' in sys.argv[1:]:
# Generate Cython sources # Generate Cython sources
generate_cython() generate_cython()


Expand Down

4 comments on commit c012492

@rgommers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this was not the only problem. You still can't checkout a release tag in a repo and install it. I don't see a clean solution yet.

@pv
Copy link
Member Author

@pv pv commented on c012492 Mar 24, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it should be some flag that is turned on only in sdist tarballs? Not sure how to do this properly...

@rgommers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best I can think of is to add something to the release scripts to modify setup.py inside the tarballs after they're written. But that's not very robust to changes in setup.py

@rgommers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking for presence of a PKG-INFO file would probably work.

Please sign in to comment.