Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The upper code lines are dead code #11884

Closed
maheshwarigagan opened this issue Apr 18, 2020 · 3 comments
Closed

The upper code lines are dead code #11884

maheshwarigagan opened this issue Apr 18, 2020 · 3 comments
Milestone

Comments

@maheshwarigagan
Copy link

scipy/scipy/stats/stats.py

Lines 3873 to 3876 in f2ec91c

n1 = data1.shape[0]
n2 = data2.shape[0]
n1 = len(data1)
n2 = len(data2)

@ilayn
Copy link
Member

ilayn commented Apr 18, 2020

Thanks for this @maheshwarigagan. Indeed they are dead. Care to open a PR?

@maheshwarigagan
Copy link
Author

@ilayn Yes, I will raise a PR shortly

@pvanmulbregt
Copy link
Contributor

These issue also happens to be addressed by the rewrite of kstest/ks_2samp in gh-11710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants