Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: circular SphericalVoronoi input #12003

Closed
tylerjereddy opened this issue May 2, 2020 · 1 comment · Fixed by #12020
Closed

MAINT: circular SphericalVoronoi input #12003

tylerjereddy opened this issue May 2, 2020 · 1 comment · Fixed by #12020
Labels
maintenance Items related to regular maintenance tasks scipy.spatial
Milestone

Comments

@tylerjereddy
Copy link
Contributor

As noted by @pmla:

[I]t has occurred to me that the Voronoi vertices for circular input are incorrect. Circular input has exactly two Voronoi vertices - one at each pole. The other "vertices" I have calculated (those in between each pair of adjacent input points) make it possible to plot regions correctly, but are not actually Voronoi vertices. If we use the actual Voronoi vertices only, we need a different mechanism for region plotting. This could be e.g. representing regions as plane normals, but this would be a big change. Otherwise we could add a note to explain that only two vertices are actual Voronoi vertices, and the rest are merely "helper" vertices for plotting.

Since circular input has provided an error or garbage in previous releases, what we're doing now is clearly better. There's also an absence of literature guidance on this scenario as far as I can tell.

I'd suggest removing the "guide vertices" between generators and document the use of i.e. geometric_slerp to achieve reasonable plots without those "guides."

We don't actually offer plotting functionality, so just documenting the suggestion seems reasonable.

One possible point of hesitation to using just two Voronoi vertices here--would sort_vertices_of_regions() handle this gracefully?

@tylerjereddy tylerjereddy added scipy.spatial maintenance Items related to regular maintenance tasks labels May 2, 2020
@pmla
Copy link
Contributor

pmla commented May 2, 2020

One possible point of hesitation to using just two Voronoi vertices here--would sort_vertices_of_regions() handle this gracefully?

It will raise an exception:

        for i in range(3):
            k = simplices[current_simplex, i]

The 'simplex' contains only two vertices. This is not actually a simplex - we can't represent the Voronoi regions as a collection of points. The Voronoi regions of all input points contain the same two Voronoi vertices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.spatial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants