Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back threadsafety workarounds for f2py versions where it's fixed #12322

Open
pv opened this issue Jun 7, 2020 · 0 comments
Open

Roll back threadsafety workarounds for f2py versions where it's fixed #12322

pv opened this issue Jun 7, 2020 · 0 comments
Labels
maintenance Items related to regular maintenance tasks task A straightforward change, verification or fix.

Comments

@pv
Copy link
Member

pv commented Jun 7, 2020

This is reminder to roll back the workaround in gh-12319 (see also gh-9658; possibly there are also other threadsafety workarounds) in some way, if Scipy is compiled with f2py versions where the bug is not present.

The complication with adding Numpy version checks here is that we'd need to check the version of Numpy used to compile Scipy, not the currently imported one. Not sure if that information is stored somewhere. Because of the ABI compatibility stuff, the former is in practice going to often be quite old Numpy, so the f2py fixes won't come in soon. We perhaps should consider for the wheel builds upgrading f2py separately.

@pv pv added task A straightforward change, verification or fix. maintenance Items related to regular maintenance tasks labels Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks task A straightforward change, verification or fix.
Projects
None yet
Development

No branches or pull requests

1 participant