Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC, CI: stats skewtest refguide failure #14282

Closed
tylerjereddy opened this issue Jun 23, 2021 · 2 comments · Fixed by #14283
Closed

DOC, CI: stats skewtest refguide failure #14282

tylerjereddy opened this issue Jun 23, 2021 · 2 comments · Fixed by #14283
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.stats
Milestone

Comments

@tylerjereddy
Copy link
Contributor

This is showing up in the CI of unrelated PRs like gh-14281 and appears to be related to small floating point precision difference (a bit outside my expertise, but pasting the raw log contents below):

021-06-22T22:42:06.0038137Z ===========
2021-06-22T22:42:06.0038731Z scipy.stats
2021-06-22T22:42:06.0039292Z ===========
2021-06-22T22:42:06.0039732Z 
2021-06-22T22:42:06.0040287Z scipy.stats.skewtest
2021-06-22T22:42:06.0044399Z --------------------
2021-06-22T22:42:06.0044659Z 
2021-06-22T22:42:06.0045354Z File "build/testenv/lib/python3.8/site-packages/scipy/stats/stats.py", line 1408, in skewtest
2021-06-22T22:42:06.0045792Z Failed example:
2021-06-22T22:42:06.0046136Z     skewtest([2, 8, 0, 4, 1, 9, 9, 0])
2021-06-22T22:42:06.0046476Z Expected:
2021-06-22T22:42:06.0046843Z     SkewtestResult(statistic=0.44626385374196975, pvalue=0.6554066631275459)
2021-06-22T22:42:06.0047232Z Got:
2021-06-22T22:42:06.0047587Z     SkewtestResult(statistic=0.4462638537419698, pvalue=0.6554066631275459)
2021-06-22T22:42:06.0047859Z 
2021-06-22T22:42:06.0047991Z 
2021-06-22T22:42:06.0048585Z File "build/testenv/lib/python3.8/site-packages/scipy/stats/stats.py", line 1410, in skewtest
2021-06-22T22:42:06.0049033Z Failed example:
2021-06-22T22:42:06.0049358Z     skewtest([1, 2, 3, 4, 5, 6, 7, 8000])
2021-06-22T22:42:06.0049693Z Expected:
2021-06-22T22:42:06.0050074Z     SkewtestResult(statistic=3.571773510360407, pvalue=0.0003545719905823133)
2021-06-22T22:42:06.0050439Z Got:
2021-06-22T22:42:06.0050811Z     SkewtestResult(statistic=3.5717735103604067, pvalue=0.00035457199058231423)
2021-06-22T22:42:06.0051078Z 
2021-06-22T22:42:06.0051208Z 
2021-06-22T22:42:06.0051811Z File "build/testenv/lib/python3.8/site-packages/scipy/stats/stats.py", line 1412, in skewtest
2021-06-22T22:42:06.0052251Z Failed example:
2021-06-22T22:42:06.0052613Z     skewtest([100, 100, 100, 100, 100, 100, 100, 101])
2021-06-22T22:42:06.0053231Z Expected:
2021-06-22T22:42:06.0053599Z     SkewtestResult(statistic=3.5717766638478072, pvalue=0.000354567720281634)
2021-06-22T22:42:06.0053977Z Got:
2021-06-22T22:42:06.0054335Z     SkewtestResult(statistic=3.5717766638478063, pvalue=0.00035456772028163574)
2021-06-22T22:42:06.0054615Z 
2021-06-22T22:42:06.0054745Z 
2021-06-22T22:42:06.0055035Z ERROR: refguide or doctests have errors
@tylerjereddy tylerjereddy added scipy.stats Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Jun 23, 2021
@ev-br
Copy link
Member

ev-br commented Jun 23, 2021

There's an issue in refguide-check, I'll take a look.

@ev-br
Copy link
Member

ev-br commented Jun 23, 2021

Locally a different one fails for me, but it's numerical noise anyway and hopefully gh-14283 makes it more robust by delegating these cases to np.allclose.

@ev-br ev-br added this to the 1.8.0 milestone Jun 24, 2021
@tylerjereddy tylerjereddy modified the milestones: 1.8.0, 1.7.1 Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.stats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants