Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP: sharpen deprecation for >1-dim inputs in optimize.minimize #15739

Closed
h-vetinari opened this issue Mar 11, 2022 · 1 comment · Fixed by #15804
Closed

DEP: sharpen deprecation for >1-dim inputs in optimize.minimize #15739

h-vetinari opened this issue Mar 11, 2022 · 1 comment · Fixed by #15804
Labels
deprecated Items related to behavior that has been deprecated scipy.optimize
Milestone
1.9.0

Comments

@h-vetinari
Copy link
Member

This comes from #15297, which only landed for 1.9. Currently the message of the deprecation warning is a bit soft:

Use of `minimize` with `x0.ndim != 1` is deprecated. Currently, singleton dimensions
will be removed from `x0`, but an error may be raised in the future.

Can we sharpen this to say that an error will be raised in version X? (1.11? 1.12?)

CC @mdhaber
@h-vetinari h-vetinari added scipy.optimize deprecated Items related to behavior that has been deprecated labels Mar 11, 2022
@mdhaber
Copy link
Contributor

mdhaber commented Mar 11, 2022

That is fine with me.

@h-vetinari h-vetinari mentioned this issue Mar 11, 2022
Open
36 tasks
@h-vetinari h-vetinari changed the title DEPR: raise on >1-dim inputs for optimize.minimize DEP: raise on >1-dim inputs for optimize.minimize Mar 16, 2022
@j-bowhay j-bowhay mentioned this issue Mar 17, 2022
Merged
@h-vetinari h-vetinari changed the title DEP: raise on >1-dim inputs for optimize.minimize DEP: sharpen deprecation for >1-dim inputs in optimize.minimize Mar 17, 2022
@h-vetinari h-vetinari mentioned this issue Mar 17, 2022
Closed
@mdhaber mdhaber added this to the 1.9.0 milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecated Items related to behavior that has been deprecated scipy.optimize
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

DEP: sharpen warning message on >1-dim for optimize.minimize j-bowhay/scipy
3 participants
@mdhaber @h-vetinari and others