Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/CI: Wrong python version used for tests labeled "Linux Tests / NumPy main" #15866

Closed
WarrenWeckesser opened this issue Mar 25, 2022 · 4 comments · Fixed by #15867
Closed

BUG/CI: Wrong python version used for tests labeled "Linux Tests / NumPy main" #15866

WarrenWeckesser opened this issue Mar 25, 2022 · 4 comments · Fixed by #15867
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure defect A clear bug or issue that prevents SciPy from being installed or used as expected
Milestone
1.9.0

Comments

@WarrenWeckesser
Copy link
Member

WarrenWeckesser commented Mar 25, 2022 •
edited

Describe your issue.

The file linux.yml in .github/workflows defines a test job test_numpy_main (with name: NumPy main), and according to the settings in that file, the job is supposed to run with Python 3.10. Error messages in test failures on the main branch show that it is actually using Python 3.8.
@WarrenWeckesser WarrenWeckesser added defect A clear bug or issue that prevents SciPy from being installed or used as expected CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Mar 25, 2022
@WarrenWeckesser
Copy link
Member Author

It looks like the relevant change was in #14832 (back in November). @tupui, do you recall why the explicit installation and use of Python 3.10 was removed for this job? It looks like the job now uses the system python, which is apparently 3.8.

@tupui
Copy link
Member

tupui commented Mar 25, 2022

Indeed, thanks for noticing this. I actually should have remove the matrix thing which confused me. I will send a PR now to fix this.

@andyfaff
Copy link
Contributor

Iirc that job was originally designed for testing pre release versions of python.

@tupui
Copy link
Member

tupui commented Mar 25, 2022 •
edited

It is yes, the job is used for latest and pre-released versions of Python + NumPy.

We just disabled this part for now until there is a RC of 3.11. This is why the matrix is still there. Also we might be able to remove the custom code because GH provides pre-release versions now. I will do this once there is a RC (I am not sure we want to test with alpha or beta). See https://github.com/actions/python-versions/releases

@tupui tupui mentioned this issue Mar 25, 2022
Merged
@tupui tupui added this to the 1.9.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure defect A clear bug or issue that prevents SciPy from being installed or used as expected
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

CI: fix python version matrix in linux workflow tupui/scipy
3 participants
@WarrenWeckesser @andyfaff @tupui