MAINT: better UNU.RAN licensing information #16158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupui
added
maintenance
mdhaber
approved these changes
May 11, 2022
|
Do you want to do anything more here? |
|
Seems like @tirthasheshpatel is saying there are mentions of the old license in other files. Maybe we wait to get this in here in one go. But it can as well get in and we do a follow up. |
|
Submitted scipy/unuran#5 |
|
@tupui if you merge scipy/unuran#5 and update the submodule here, I'll merge this one. |
|
Done, thanks all for the reactivity 💪 |
|
Can you run the CI to confirm the UNU.RAN code is still working? I removed the GPL references through a search and replace so, small chances of something slipping through that might have edited unintended source code. |
|
Prerelease has been timing out. No new failures, so merging. |
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
May 15, 2022
MAINT: better/corrected UNU.RAN licensing information
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tylerjereddy marking this one as well. Same as the other one, up to you to decide what to do in this situation.