Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: latest version of flake8 breaks tools/lint_diff.py #17503

Closed
j-bowhay opened this issue Nov 27, 2022 · 2 comments
Closed

BUG: latest version of flake8 breaks tools/lint_diff.py #17503

j-bowhay opened this issue Nov 27, 2022 · 2 comments
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected DX Everything related to making the experience of working on SciPy more pleasant

Comments

@j-bowhay
Copy link
Member

https://flake8.pycqa.org/en/latest/release-notes/6.0.0.html#backwards-incompatible-changes

Flake8 version 6.0.0 removed the --diff flag which breaks tools/lint_diff.py
@j-bowhay j-bowhay added defect A clear bug or issue that prevents SciPy from being installed or used as expected DX Everything related to making the experience of working on SciPy more pleasant labels Nov 27, 2022
@j-bowhay j-bowhay mentioned this issue Nov 27, 2022
Merged
@rgommers
Copy link
Member

Oh yes, they decided to break the world. Can we just pin it to <6.0 in environment.yml? This is not a defect, we need to run on the diff only. Running on the whole code base is a nonstarter.

@j-bowhay
Copy link
Member Author

closed via #17496

@j-bowhay j-bowhay mentioned this issue Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected DX Everything related to making the experience of working on SciPy more pleasant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgommers @j-bowhay