Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: special: pbvv_seq is broken. #17681

Closed
WarrenWeckesser opened this issue Dec 30, 2022 · 3 comments · Fixed by #19824
Closed

BUG: special: pbvv_seq is broken. #17681

WarrenWeckesser opened this issue Dec 30, 2022 · 3 comments · Fixed by #19824
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.special
Milestone

Comments

@WarrenWeckesser
Copy link
Member

WarrenWeckesser commented Dec 30, 2022

The function scipy.special.pbvv_seq fails to run:

In [1]: import scipy

In [2]: scipy.__version__
Out[2]: '1.11.0.dev0+1208.2af3085'

In [3]: from scipy.special import pbvv_seq

In [4]: pbvv_seq(3, 1.5)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In [4], line 1
----> 1 pbvv_seq(3, 1.5)

File ~/repos/git/forks/scipy/build-install/lib/python3.10/site-packages/scipy/special/_basic.py:2235, in pbvv_seq(v, x)
   2233     n1 = n
   2234 v1 = n1 + v0
-> 2235 dv, dp, pdf, pdd = _specfun.pbvv(v1, x)
   2236 return dv[:n1+1], dp[:n1+1]

AttributeError: module 'scipy.special._specfun' has no attribute 'pbvv'

This function has no tests, otherwise we would have caught this issue a long time ago. I don't know how long it has been broken. If it has never worked, we could consider simply deleting it. Edit: pbvv_seq was discussed in #4957, so apparently it was working back in 2015.

@WarrenWeckesser WarrenWeckesser added defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.special labels Dec 30, 2022
@tupui
Copy link
Member

tupui commented Dec 30, 2022

+1 for the deletion if it's not working since a few releases. If no one is complaining, probably not used.

@WarrenWeckesser
Copy link
Member Author

After reading #4957, it is clear that pbvv_seq has worked in the past. It broke some time after that issue was reported in 2015.

@steppi
Copy link
Contributor

steppi commented Dec 3, 2023

It seems the wrapper for pbvv was inadvertently removed in #11740, and this went unnoticed because it wasn't tested. We can just put it back (and anything else which shouldn't have been removed) and add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.special
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants