Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: warning from scipy/special/special/gamma.h #20587

Open
ev-br opened this issue Apr 26, 2024 · 2 comments
Open

BLD: warning from scipy/special/special/gamma.h #20587

ev-br opened this issue Apr 26, 2024 · 2 comments
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS scipy.special

Comments

@ev-br
Copy link
Member

ev-br commented Apr 26, 2024

There's a new warning when building main:

[32/247] Compiling C++ object scipy/specia...86_64-linux-gnu.so.p/_special_ufuncs.cpp.o
In file included from ../scipy/special/_special_ufuncs.cpp:15:
../scipy/special/special/gamma.h: In function 'std::complex<_Tp> special::gamma(std::complex<_Tp>) [with T = float]':
../scipy/special/special/gamma.h:19:44: warning: infinite recursion detected [-Winfinite-recursion]
   19 | SPECFUN_HOST_DEVICE inline std::complex<T> gamma(std::complex<T> z) {
      |                                            ^~~~~
../scipy/special/special/gamma.h:20:17: note: recursive call
   20 |     return gamma(z);
      |            ~~~~~^~~
@ilayn
Copy link
Member

ilayn commented Apr 26, 2024

Also #20390 (review) and a few times this has been discussed but can't remember where. At some point we have to clean up the C++ overhaul. Since 1.13 is out we don't have the time pressure anymore.

@ev-br
Copy link
Member Author

ev-br commented Apr 26, 2024

Feel free to close if it's known

@lucascolley lucascolley changed the title build warning from scipy.special BLD: warning from scipy/special/special/gamma.h Apr 26, 2024
@lucascolley lucascolley added the Build issues Issues with building from source, including different choices of architecture, compilers and OS label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS scipy.special
Projects
None yet
Development

No branches or pull requests

4 participants
@ilayn @ev-br @lucascolley and others