Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciPy's complex erf code is not free/open-source? (Trac #1741) #2260

Closed
scipy-gitbot opened this issue Apr 25, 2013 · 4 comments
Closed

SciPy's complex erf code is not free/open-source? (Trac #1741) #2260

scipy-gitbot opened this issue Apr 25, 2013 · 4 comments
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected Migrated from Trac scipy.special
Milestone

Comments

@scipy-gitbot
Copy link

Original ticket http://projects.scipy.org/scipy/ticket/1741 on 2012-10-05 by trac user stevenj, assigned to @pv.

The complex error function implementation in SciPy seems to use the subroutine WOFZ published in ACM Transactions on Mathematical Software (TOMS):

https://github.com/scipy/scipy/blob/master/scipy/special/toms/wofz.f

ACM TOMS code is generally NOT free/open-source software: it falls under the ACM Software copyright (http://www.acm.org/publications/policies/softwarecrnotice) which is free-of-charge only for noncommercial use.

I came across this because I was looking for a free/open-source complex erf routine to use in our own code; we originally wanted to use the TOMS code, but reluctantly concluded that it was unusable because of licensing. As an alternative, I wrote an independent implementation of another algorithm (which seems to be a bit more accurate than WOFZ) and released it as free/open-source software: http://ab-initio.mit.edu/wiki/index.php/Faddeeva_w

@scipy-gitbot
Copy link
Author

@rgommers wrote on 2012-10-05

Thanks for reporting this. I asked on scipy-dev if anyone remembers a discussion on the license of this function: http://article.gmane.org/gmane.comp.python.scientific.devel/16970

Some other TOMS functions were specifically relicensed as BSD after Scipy devs asked ACM, but not this one (or at least I can't find it in the list archive).

@scipy-gitbot
Copy link
Author

@pv wrote on 2012-10-06

We can just replace it. That code was added pre-2001, so the only one knowing about this would probably be Travis.

Here's PR: #331

@scipy-gitbot
Copy link
Author

@rgommers wrote on 2012-10-10

PR is merged. Thanks Steven, both for pointing out the issue and writing a suitably licensed replacement.

@scipy-gitbot
Copy link
Author

Milestone changed to 0.12.0 by @rgommers on 2012-10-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected Migrated from Trac scipy.special
Projects
None yet
Development

No branches or pull requests

1 participant