Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

names for temporary files and folders generated by weave are too large for MSVC #3231

Closed
bbudescu opened this issue Jan 22, 2014 · 2 comments
Labels
duplicate Issues that describe the same problem or that are reported multiple times

Comments

@bbudescu
Copy link

MSVC has a max length of 260 chars for input/output paths, which is exceeded when using weave. A possible solution (which I tested and seems to work) is to modify the unique name generation algorithm by making it use md5 hex checksums instead of sha256 (which are 64 characters long). The places where I made the modifications are in catalog.expr_to_filename (https://github.com/scipy/scipy/blob/master/scipy/weave/catalog.py#L93) and platform_info.check_sum (https://github.com/scipy/scipy/blob/master/scipy/weave/platform_info.py#L99). This is also caused by the fact that the path to the output obj also replicates the whole path of the cpp.

@rgommers
Copy link
Member

This is a duplicate of gh-3216. I actually plan to fix that today and then release 0.13.3 asap.

Thanks for the suggested fixes.

@rgommers
Copy link
Member

Fix submitted: gh-3232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues that describe the same problem or that are reported multiple times
Projects
None yet
Development

No branches or pull requests

2 participants