Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imresize cannot be deprecated just yet #8843

Closed
Atcold opened this issue May 18, 2018 · 6 comments
Closed

imresize cannot be deprecated just yet #8843

Atcold opened this issue May 18, 2018 · 6 comments
Milestone

Comments

@Atcold
Copy link
Contributor

Atcold commented May 18, 2018

Using imresize I get the following warning

`imresize` is deprecated in SciPy 1.0.0, and will be removed in 1.2.0.
Use ``skimage.transform.resize`` instead.

skimage.transform.resize and .scale do not have any interpolation option, so it is not a viable replacement for imresize. Now I'm not sure I should open an issue at skimage or here. I start here because your routine is actually more versatile than skimage's.

@pv
Copy link
Member

pv commented May 18, 2018 via email

@Atcold
Copy link
Contributor Author

Atcold commented May 23, 2018

Fine, then what about pointing that out in the warning message?
skimage.transform.resize is way too limited.

@ev-br
Copy link
Member

ev-br commented Jun 17, 2018

@Atcold care to submit a PR with an enhancement to the deprecation message?

@rgommers rgommers added this to the 1.2.0 milestone Jun 17, 2018
@Atcold
Copy link
Contributor Author

Atcold commented Jun 18, 2018

Yes, I can. I'll do it later, this week.

@Atcold
Copy link
Contributor Author

Atcold commented Jun 25, 2018

Done here #8971
I hope it's fine.

@ev-br
Copy link
Member

ev-br commented Aug 26, 2018

Closed by #8971

@ev-br ev-br closed this as completed Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants