You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a useful function, but I've noticed that its performance on data composed of nearby peaks is much worse than on data that is more spread out. I think this is likely because the default value for window_size in _filter_ridge_lines is just the number of original data points divided by 20. In cases where peaks are relatively close together, points that lie on neighboring peaks are included in the noise floor calculation! I've noticed this problem is particularly bad if a peak is found midway between two larger neighbors.
This window size should probably be an argument to find_peaks_cwt anyway, but I would further propose that the default window be something more like 4 * max(cwt[0]), or 4 times the width of the largest wavelet scale, since the wavelet scales are already intuitively related to expected peak widths.
The text was updated successfully, but these errors were encountered:
@chelsell can you provide some examples where using your proposed default value leads to an improvement of the result? If there is an improvement for most cases, we can consider changing the default value.
This is a useful function, but I've noticed that its performance on data composed of nearby peaks is much worse than on data that is more spread out. I think this is likely because the default value for
window_size
in_filter_ridge_lines
is just the number of original data points divided by 20. In cases where peaks are relatively close together, points that lie on neighboring peaks are included in the noise floor calculation! I've noticed this problem is particularly bad if a peak is found midway between two larger neighbors.This window size should probably be an argument to
find_peaks_cwt
anyway, but I would further propose that the default window be something more like 4 * max(cwt[0]), or 4 times the width of the largest wavelet scale, since the wavelet scales are already intuitively related to expected peak widths.The text was updated successfully, but these errors were encountered: