Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility breakage #27

Open
3 of 14 tasks
pravic opened this issue Apr 5, 2018 · 0 comments
Open
3 of 14 tasks

Compatibility breakage #27

pravic opened this issue Apr 5, 2018 · 0 comments
Assignees

Comments

@pravic
Copy link
Member

pravic commented Apr 5, 2018

  • sciter::Value: remove indexing (works via a hack now)
  • sciter::Value::isolate should be unsafe
  • s2w : return a single value only, s2wn returns value and length
  • window::with_size and K°: use window::Builder instead.
  • window size as array instead of tuple: [width, height] (why? totally forgot now)
  • window creation as result
  • proper error type (probably will break return types) - though our return types are compatible with std::error::Error now
  • Window::load_html and Window::load_file should return bool (even better - a proper Result)
  • Window::load_html and Window::load_file should return a proper Result
  • Window::load_file should accept AsPath trait
  • dom::Element:: get_value, get_hwnd, attribute, get_style_attribute should return result
  • dom::Element:: from_window, from_point, from_focus, from_highlighted should return Result<Option<Element>>
  • dom::Element:: get_tag, get_text should return a proper result
  • replace enums with associated constants Replace enums with associated constants  #92
@pravic pravic self-assigned this Apr 5, 2018
@pravic pravic changed the title Compatability breakage Compatibility breakage Jun 19, 2020
@pravic pravic pinned this issue Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant