Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories backup and backups mixed up #45

Closed
shortbloke opened this issue Mar 5, 2019 · 2 comments
Closed

Directories backup and backups mixed up #45

shortbloke opened this issue Mar 5, 2019 · 2 comments

Comments

@shortbloke
Copy link
Contributor

The backup script copies the resultant backup .tar.gz file to /backup however readme indicates it should be /backups
The docker-compose files also map /backups which then doesn't work as the backups are created within the container not in the mapped volume.

I'd submit changes, but I'm not sure if you'd prefer backup or backups to be used. It does contain multiple so the plural would make more sense. This would need the backup.sh to be updated and the readme.

@shortbloke
Copy link
Contributor Author

I've created a suggested PR, in case that helps.

@scline
Copy link
Owner

scline commented Mar 6, 2019

Closing since you created a PR that was merged, thank you!

@scline scline closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants