-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use :: for library separation #80
Comments
It's not portable shell idiom, and so I don't like that (as a lot of things in that document). |
I wanted just to hear more opinions, not that I'd push on that either. Thanks for the feedback so far, I'd keep this open to see more feedback, but I agree that without a good reason to change it, it's not worth it. |
In my point of view, portability of this project isn't so important. But I'm also thinking if the readability of the new format is so better, that it makes sense to rewrite tests for several images... |
Imo the readability improves by a bit but I do not think it is worth the change, considering we would need to change all of the images to the new format (or keep both for compatibility I guess) |
I agree it's not worth it, closing. |
https://google.github.io/styleguide/shell.xml#Function_Names suggests to use
::
separator for libraries separation, so we can end up with something like:instead of
The text was updated successfully, but these errors were encountered: